On Thu, Aug 15, 2019 at 10:08:00PM +1000, Herbert Xu wrote: > On Fri, Aug 09, 2019 at 08:14:57PM +0300, Ard Biesheuvel wrote: > > Add support for the missing ciphertext stealing part of the XTS-AES > > specification, which permits inputs of any size >= the block size. > > > > Cc: Pascal van Leeuwen <pvanleeuwen@xxxxxxxxxxxxxx> > > Cc: Ondrej Mosnacek <omosnace@xxxxxxxxxx> > > Tested-by: Milan Broz <gmazyland@xxxxxxxxx> > > Signed-off-by: Ard Biesheuvel <ard.biesheuvel@xxxxxxxxxx> > > --- > > v2: fix scatterlist issue in async handling > > remove stale comment > > > > crypto/xts.c | 152 +++++++++++++++++--- > > 1 file changed, 132 insertions(+), 20 deletions(-) > > Patch applied. Thanks. > -- I'm confused why this was applied as-is, since there are no test vectors for this added yet. Nor were any other XTS implementations updated yet, so now users see inconsistent behavior, and all the XTS comparison fuzz tests fail. What is the plan for addressing these? I had assumed that as much as possible would be fixed up at once. - Eric
