On 2019/8/15 20:03, Herbert Xu wrote: > This patch fixes a printk format warning by replacing %p with %#lx > for dma_addr_t. > > Signed-off-by: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> > > diff --git a/drivers/crypto/hisilicon/qm.c b/drivers/crypto/hisilicon/qm.c > index d72e062..3095284 100644 > --- a/drivers/crypto/hisilicon/qm.c > +++ b/drivers/crypto/hisilicon/qm.c > @@ -347,8 +347,8 @@ static int qm_mb(struct hisi_qm *qm, u8 cmd, dma_addr_t dma_addr, u16 queue, > struct qm_mailbox mailbox; > int ret = 0; > > - dev_dbg(&qm->pdev->dev, "QM mailbox request to q%u: %u-%pad\n", queue, > - cmd, dma_addr); > + dev_dbg(&qm->pdev->dev, "QM mailbox request to q%u: %u-%#lxad\n", > + queue, cmd, (unsigned long)dma_addr); Thanks. However, to be honest I can't get why we fix it like this. Can you give me a clue? > > mailbox.w0 = cmd | > (op ? 0x1 << QM_MB_OP_SHIFT : 0) | >
