On Thu, Aug 15, 2019 at 08:43:38AM +0300, Ard Biesheuvel wrote: > > So I will end up with > > static inline int verify_skcipher_des_key(struct crypto_skcipher *tfm, > const u8 *key) > static inline int verify_skcipher_des3_key(struct crypto_skcipher *tfm, > const u8 *key) > static inline int verify_ablkcipher_des_key(struct crypto_skcipher *tfm, > const u8 *key) > static inline int verify_ablkcipher_des3_key(struct crypto_skcipher *tfm, > const u8 *key) > static inline int verify_aead_des3_key(struct crypto_aead *tfm, const u8 *key, > int keylen) > static inline int verify_aead_des_key(struct crypto_aead *tfm, const u8 *key, > int keylen) > > Is that what you had in mind? Yes and hopefully we will be able to get rid of ablkcipher at some point. As a rule we want to make the job as easy as possible for driver authors so we should leave the burden of such trivial things with the API. Thanks, -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
