On Tue, Jul 30, 2019 at 11:15:05AM -0700, Stephen Boyd wrote: > We don't need dev_err() messages when platform_get_irq() fails now that > platform_get_irq() prints an error message itself when something goes > wrong. Let's remove these prints with a simple semantic patch. > > // <smpl> > @@ > expression ret; > struct platform_device *E; > @@ > > ret = > ( > platform_get_irq(E, ...) > | > platform_get_irq_byname(E, ...) > ); > > if ( \( ret < 0 \| ret <= 0 \) ) > { > ( > -if (ret != -EPROBE_DEFER) > -{ ... > -dev_err(...); > -... } > | > ... > -dev_err(...); > ) > ... > } > // </smpl> > > While we're here, remove braces on if statements that only have one > statement (manually). > > Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> > Cc: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> > Cc: "David S. Miller" <davem@xxxxxxxxxxxxx> > Cc: <linux-crypto@xxxxxxxxxxxxxxx> > Signed-off-by: Stephen Boyd <swboyd@xxxxxxxxxxxx> > --- > > Please apply directly to subsystem trees > > drivers/crypto/atmel-aes.c | 1 - > drivers/crypto/atmel-sha.c | 1 - > drivers/crypto/atmel-tdes.c | 1 - > drivers/crypto/ccree/cc_driver.c | 4 +--- > drivers/crypto/img-hash.c | 1 - > drivers/crypto/mediatek/mtk-platform.c | 4 +--- > drivers/crypto/mxs-dcp.c | 8 ++------ > drivers/crypto/omap-aes.c | 1 - > drivers/crypto/omap-des.c | 1 - > drivers/crypto/omap-sham.c | 1 - > drivers/crypto/sahara.c | 4 +--- > drivers/crypto/stm32/stm32-cryp.c | 4 +--- > drivers/crypto/stm32/stm32-hash.c | 4 +--- > 13 files changed, 7 insertions(+), 28 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt