On Thu, 8 Aug 2019 at 00:33, Jarkko Sakkinen <jarkko.sakkinen@xxxxxxxxxxxxxxx> wrote: > > On Tue, Aug 06, 2019 at 07:07:19PM +0530, Sumit Garg wrote: > > Move TPM2 trusted keys code to trusted keys subsystem. > > Missing a long description. The reason is that it is better consolidate > all trusted keys code to a single location so that it can be maintained > sanely and it should be stated here. Sure will extend the description. > > > Suggested-by: Jarkko Sakkinen <jarkko.sakkinen@xxxxxxxxxxxxxxx> > > Signed-off-by: Sumit Garg <sumit.garg@xxxxxxxxxx> > > I would suggest adding at least two commits before this: > > - A commit that just exports tpm_buf stuff and TPM2 constants to > include/linux Okay, will create a separate patch for this. > - A commit that just changes the existing TPM 1.x trusted keys > code to use tpm_buf. It seems to be a functional change which I think requires proper unit testing. I am afraid that I don't posses a TPM device to test this and also very less conversant with tpm_buf code. So what I have done here is to rename existing TPM 1.x trusted keys code to use tpm1_buf. And I would be happy to integrate a tested patch if anyone familiar could work on this. -Sumit > > These should be before the current 1/3 commit. > > /Jarkko
