On Fri, Aug 02, 2019 at 11:20:09AM +0530, Sumit Garg wrote: > On Thu, 1 Aug 2019 at 22:54, Jarkko Sakkinen > <jarkko.sakkinen@xxxxxxxxxxxxxxx> wrote: > > > > On Thu, Jul 18, 2019 at 04:54:45PM +0530, Sumit Garg wrote: > > > Move existing code to trusted keys subsystem. Also, rename files with > > > "tpm" as suffix which provides the underlying implementation. > > > > > > Suggested-by: Jarkko Sakkinen <jarkko.sakkinen@xxxxxxxxxxxxxxx> > > > Signed-off-by: Sumit Garg <sumit.garg@xxxxxxxxxx> > > > > What about TPM2 trusted keys code? > > Isn't TPM2 code located here: "drivers/char/tpm/"? Would you like to > move that code under trusted keys subsystem only? Yeah, we need a design decision here. What I care is that they should be in the same subsystem. I did trusted keys directly to TPM 2.0 subsys because the subsystem was not too robust back then. Right now I think it would be feasible to implement TPM2 trusted keys outside TPM driver since the whole transmit functionality is way more robust. /Jarkko
