Hello, On Fri, Aug 02, 2019 at 09:28:02PM +0800, YueHaibing wrote: > Use devm_platform_ioremap_resource() to simplify the code a bit. > This is detected by coccinelle. > > Reported-by: Hulk Robot <hulkci@xxxxxxxxxx> > Signed-off-by: YueHaibing <yuehaibing@xxxxxxxxxx> Acked-by: Antoine Tenart <antoine.tenart@xxxxxxxxxxx> Thanks, Antoine > --- > drivers/crypto/inside-secure/safexcel.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/crypto/inside-secure/safexcel.c b/drivers/crypto/inside-secure/safexcel.c > index d1f60fd..822744d 100644 > --- a/drivers/crypto/inside-secure/safexcel.c > +++ b/drivers/crypto/inside-secure/safexcel.c > @@ -999,7 +999,6 @@ static void safexcel_init_register_offsets(struct safexcel_crypto_priv *priv) > static int safexcel_probe(struct platform_device *pdev) > { > struct device *dev = &pdev->dev; > - struct resource *res; > struct safexcel_crypto_priv *priv; > int i, ret; > > @@ -1015,8 +1014,7 @@ static int safexcel_probe(struct platform_device *pdev) > > safexcel_init_register_offsets(priv); > > - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - priv->base = devm_ioremap_resource(dev, res); > + priv->base = devm_platform_ioremap_resource(pdev, 0); > if (IS_ERR(priv->base)) { > dev_err(dev, "failed to get resource\n"); > return PTR_ERR(priv->base); > -- > 2.7.4 > > -- Antoine Ténart, Bootlin Embedded Linux and Kernel engineering https://bootlin.com