On Sat, Jul 27, 2019 at 02:17:38PM +0200, Martin Blumenstingl wrote: > Hi Corentin, > > it's great to see you working on this :) > > On Thu, Jul 25, 2019 at 9:45 PM Corentin Labbe <clabbe@xxxxxxxxxxxx> wrote: > > > > This patch adds support for the amlogic GXL cryptographic offloader present > > on GXL SoCs. > > > > This driver supports AES cipher in CBC/ECB mode. > > > > Signed-off-by: Corentin Labbe <clabbe@xxxxxxxxxxxx> > > --- > > drivers/crypto/Kconfig | 2 + > > drivers/crypto/Makefile | 1 + > > drivers/crypto/amlogic/Kconfig | 24 ++ > > drivers/crypto/amlogic/Makefile | 2 + > > drivers/crypto/amlogic/amlogic-cipher.c | 358 ++++++++++++++++++++++++ > > drivers/crypto/amlogic/amlogic-core.c | 326 +++++++++++++++++++++ > > drivers/crypto/amlogic/amlogic.h | 172 ++++++++++++ > > 7 files changed, 885 insertions(+) > > create mode 100644 drivers/crypto/amlogic/Kconfig > > create mode 100644 drivers/crypto/amlogic/Makefile > > create mode 100644 drivers/crypto/amlogic/amlogic-cipher.c > > create mode 100644 drivers/crypto/amlogic/amlogic-core.c > > create mode 100644 drivers/crypto/amlogic/amlogic.h > there are two different crypto IPs on Amlogic SoCs: > - GXL and newer use the "BLKMV" crypto IP > - GXBB, Meson8/Meson8b/Meson8m2 (and probably older SoCs) use the > "NDMA" crypto IP > I believed it was the opposite. (BLKMV the older, NDMA the newer) Anyway, on the datasheet I found (s905d), neither NDMA or BLKMV is mentioned, it is just called Crypto Engine. So I think GXL is the best choice. > personally I think it makes sense to either have the IP name (blkmv) > or SoC name (GXL) in the file or directory names as well as being > consistent with that in the Kconfig option names Ok I will rename files to amlogic-gxl-xxx Thanks
