> -----Original Message----- > From: Antoine Tenart <antoine.tenart@xxxxxxxxxxx> > Sent: Wednesday, July 31, 2019 2:13 PM > To: Pascal Van Leeuwen <pvanleeuwen@xxxxxxxxxxxxxx> > Cc: Antoine Tenart <antoine.tenart@xxxxxxxxxxx>; Pascal van Leeuwen > <pascalvanl@xxxxxxxxx>; linux-crypto@xxxxxxxxxxxxxxx; herbert@xxxxxxxxxxxxxxxxxxx; > davem@xxxxxxxxxxxxx > Subject: Re: [PATCHv2 2/3] crypto: inside-secure - add support for PCI based FPGA > development board > > > > > > You're moving the default choice from "no firmware" to being a specific > > > > > one. > > > > > > > > > The EIP97 being the exception as the only firmware-less engine. > > > > This makes EIP197_DEVBRD fall through to EIP197B firmware until > > > > my patches supporting other EIP197 configs eventually get merged, > > > > after which this part will change anyway. > > > > > > We don't know when/in what shape those patches will be merged, so in > > > the meantime please make the "no firmware" the default choice. > > > > > "No firmware" is not possible with an EIP197. Trying to use it without > > loading firmware will cause it to hang, which I don't believe is what > > you would want. So the alternative would be to return an error, which > > is fine by me, so then I'll change it into that as default. > > Sure. When you look at this it's just weird to have a specific firmware > tied to an 'else' without having a check for a given version. Having the > "no firmware" option as the default option or not does not change > anything at runtime in practice here. If you prefer throwing an error if > the version isn't supported, I'm OK with it as well. > Agree that it was weird, not loading anything was bad too. Glad that we both agree on throwing an error :-) Regards, Pascal van Leeuwen Silicon IP Architect, Multi-Protocol Engines @ Verimatrix www.insidesecure.com
