On Wed, Jul 31, 2019 at 10:19:30AM +0200, Hans de Goede wrote: > On 30-07-19 22:07, Eric Biggers wrote: > > >Well, seems like the solution needs to involve unifying the implementations. > > > >Note that Ard Biesheuvel recently added the arc4 and aes algorithms to > >lib/crypto/, with options CONFIG_CRYPTO_LIB_ARC4 and CONFIG_CRYPTO_LIB_AES. How > >about following the same convention, rather than doing everything slightly > >differently w.r.t. code organization, function naming, Kconfig option, etc.? > > I'm fine with that, I'm still waiting for feedback from the crypto maintainers > that they are open to doing that ... > > Herbert? Dave? I fully agree with what Eric said. Cheers, -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt