Hi, On 30-07-19 15:15, Stephan Mueller wrote:
Am Dienstag, 30. Juli 2019, 14:38:35 CEST schrieb Hans de Goede: Hi Hans,From: Andy Lutomirski <luto@xxxxxxxxxx> This just moves code around -- no code changes in this patch. This wil let BPF-based tracing link against the SHA256 core code without depending on the crypto core. Cc: Ard Biesheuvel <ard.biesheuvel@xxxxxxxxxx> Cc: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Signed-off-by: Andy Lutomirski <luto@xxxxxxxxxx> --- crypto/Kconfig | 8 + crypto/Makefile | 1 + crypto/{sha256_generic.c => sha256_direct.c} | 103 +--------There is a similar standalone code present for SHA-1 or ChaCha20. However, this code lives in lib/. Thus, shouldn't the SHA-256 core code be moved to lib/ as well?
lib/ actually already has a sha256 implementation: lib/sha256.c but that is currently only used by the x86 and s390 purgatory code. Ideally the 2 would be merged I guess ... Regards, Hans
