Re: [PATCH] crypto: inside-secure - remove unused struct entry

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Pascal,

On Fri, Jul 05, 2019 at 02:54:25PM +0000, Pascal Van Leeuwen wrote:
> > From: Antoine Tenart <antoine.tenart@xxxxxxxxxxx>
> > On Fri, Jul 05, 2019 at 02:32:46PM +0000, Pascal Van Leeuwen wrote:
> > > > From: Antoine Tenart <antoine.tenart@xxxxxxxxxxx>
> > > >
> > > > You should wait for either those patches to be merged (or directly
> > > > integrate this change in a newer version of those patches), or send this
> > > > patch in the same series. Otherwise it's problematic as you do not know
> > > > which patches will be applied first.
> > >
> > > This patch indeed depends on earlier patches. I was just assuming
> > > people to be smart enough to apply the patches in the correct order :-)
> > 
> > It's actually very difficult for a maintainer to remember this,
> > especially when he has to deal with plenty of patches from many
> > contributors. And some series can take time to be merged while others
> > can be accepted easily, so it's hard to keep track of dependencies :)
> > 
> That's an interesting point though, as dependencies between more 
> complex/larger patches are rather unavoidable ...
> 
> So how should you handle that? Do you need to wait for the previous
> patches to be accepted before submitting the next ones? Thats seems
> rather inefficient as I could already be getting some (low-hanging fruit)
> feedback on the next patchset that I can already work on while waiting 
> for the previous patchset(s) to go through the process.
> 
> I'm a hardware guy. We pipeline stuff by default :-)

Hehe :)

I'd say you usually try not to send too many patches / series in
parallel. If that is not possible, or if you have series with
dependencies you can explain the dependency in the cover letter (just
try not to have 10's of series with dependencies in parallel).

Also if you have series not aimed to be merged right now but you want
comments, you can use [RFC] instead of [PATCH] in the object of the
mail.

This is usually working quite OK :)

Antoine

-- 
Antoine Ténart, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com



[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]

  Powered by Linux