On Fri, Jul 05, 2019 at 02:43:16PM +0000, Pascal Van Leeuwen wrote: > > From: Antoine Tenart <antoine.tenart@xxxxxxxxxxx> > > On Tue, Jul 02, 2019 at 04:39:53PM +0200, Pascal van Leeuwen wrote: > > > From: Pascal van Leeuwen <pvanleeuwen@xxxxxxxxxxxxxxxx> > > > > > + if (rdesc->descriptor_overflow) > > > + dev_err(priv->dev, "Descriptor overflow detected"); > > > + > > > + if (rdesc->buffer_overflow) > > > + dev_err(priv->dev, "Buffer overflow detected"); > > > > You're not returning an error here, is there a reason for that? > > > I guess the reason for that would be that it's a driver internal error, but the > result may still be just fine ... so I do want testmgr to continue its checks. > These should really only fire during driver development, see answer below. > > > I also remember having issues when adding those checks a while ago, Did > > you see any of those two error messages when using the crypto engine? > > > Only during development when I implemented things not fully correctly. OK, that makes sense. Thanks! Antoine -- Antoine Ténart, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
