On Wed, Jun 26, 2019 at 10:40:42PM +0200, Ard Biesheuvel wrote:
> diff --git a/fs/crypto/keyinfo.c b/fs/crypto/keyinfo.c
> index dcd91a3fbe49..82c7eb86ca00 100644
> --- a/fs/crypto/keyinfo.c
> +++ b/fs/crypto/keyinfo.c
> @@ -19,8 +19,6 @@
> #include <crypto/skcipher.h>
> #include "fscrypt_private.h"
Can you remove the includes that become unused as a result of this patch?
#include <crypto/aes.h>
#include <crypto/sha.h>
> @@ -495,7 +412,6 @@ static void put_crypt_info(struct fscrypt_info *ci)
> put_master_key(ci->ci_master_key);
> } else {
> crypto_free_skcipher(ci->ci_ctfm);
> - crypto_free_cipher(ci->ci_essiv_tfm);
> }
> kmem_cache_free(fscrypt_info_cachep, ci);
Nit: should remove the curly braces here.
- Eric
