On 6/27/2019 3:03 PM, Ard Biesheuvel wrote: > n my effort to remove crypto_alloc_cipher() invocations from non-crypto > code, i ran into a DES call in the CIFS driver. This is addressed in > patch #30. > > The other patches are cleanups for the quirky DES interface, and lots > of duplication of the weak key checks etc. > > Changes since v1/RFC: > - fix build errors in various drivers that i failed to catch in my > initial testing > - put all caam changes into the correct patch > - fix weak key handling error flagged by the self tests, as reported > by Eric. I am seeing a similar (?) issue: alg: skcipher: ecb-des-caam setkey failed on test vector 4; expected_error=-22, actual_error=-126, flags=0x100101 crypto_des_verify_key() in include/crypto/internal/des.h returns -ENOKEY, while testmgr expects -EINVAL (setkey_error = -EINVAL in the test vector). I assume crypto_des_verify_key() should return -EINVAL, not -ENOKEY. Horia
