On 6/17/2019 7:04 PM, Andrey Smirnov wrote: > Exactly the same code to figure out DMA mask is repeated twice in the > driver code. To avoid repetition, move that logic into a standalone > subroutine in intern.h. While at it re-shuffle the code to make it > more readable with early returns. > > Signed-off-by: Andrey Smirnov <andrew.smirnov@xxxxxxxxx> > Cc: Chris Spencer <christopher.spencer@xxxxxxxxx> > Cc: Cory Tusar <cory.tusar@xxxxxxxx> > Cc: Chris Healy <cphealy@xxxxxxxxx> > Cc: Lucas Stach <l.stach@xxxxxxxxxxxxxx> > Cc: Horia Geantă <horia.geanta@xxxxxxx> > Cc: Aymen Sghaier <aymen.sghaier@xxxxxxx> > Cc: Leonard Crestez <leonard.crestez@xxxxxxx> > Cc: linux-crypto@xxxxxxxxxxxxxxx > Cc: linux-kernel@xxxxxxxxxxxxxxx Reviewed-by: Horia Geantă <horia.geanta@xxxxxxx> Being the 1st patch in the series and not i.MX8-specific, I'd say it should be merged separately. Thanks, Horia
