On Sat, Jun 22, 2019 at 02:31:12AM +0200, Ard Biesheuvel wrote: > Some legacy code in the CIFS driver uses single DES to calculate > some password hash, and uses the crypto cipher API to do so. Given > that there is no point in invoking an accelerated cipher for doing > 56-bit symmetric encryption on a single 8-byte block of input, the > flexibility of the crypto cipher API does not add much value here, > and so we're much better off using a library call into the generic > C implementation. > > Signed-off-by: Ard Biesheuvel <ard.biesheuvel@xxxxxxxxxx> > --- > fs/cifs/Kconfig | 2 +- > fs/cifs/smbencrypt.c | 18 +++++++++--------- > 2 files changed, 10 insertions(+), 10 deletions(-) You could also remove the: MODULE_SOFTDEP("pre: des"); ... like was done for arc4. - Eric