On Sat, Jun 22, 2019 at 02:30:43AM +0200, Ard Biesheuvel wrote: > The recently added helper routines to perform key strength validation > of 3ede_keys is slightly inadequate, since it doesn't check the key > length, and it comes in two versions, neither of which are highly The skcipher helper doesn't need to check the key length because it's the responsibility of the crypto API to check the key length through min_keysize/max_keysize. But yes if you're going to do a helper for lib/des then you'd need to check the key length but please keep it separate from the skcipher helper. Thanks, -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
