On Fri, 21 Jun 2019 at 03:07, Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> wrote: > > On Thu, Jun 20, 2019 at 03:53:45PM +0200, Ard Biesheuvel wrote: > > > > We'd need at least 512 and 4k for dm-crypt, but I don't think the > > sector size is limited at all tbh > > In that case my preference would be to encode this into the key > and hardware that encounters unsupported sector sizes can use a > fallback. > OTOH, it also depends on what makes sense to implement in practice. Gilad, I suppose sector size 512 is an obvious win, since the OS always fetches at least 8 consective ones at a time. Do you see a benefit for other sector sizes as well?