Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > When calling debugfs functions, there is no need to ever check the > return value. The function can work or not, but the code logic should > never do something different based on this. > > Also, there is no need to store the individual debugfs file names, > especially as the whole directiry is deleted at once, so remove the > unneeded structure entirely. > > Cc: "Breno Leitão" <leitao@xxxxxxxxxx> > Cc: Nayna Jain <nayna@xxxxxxxxxxxxx> > Cc: Paulo Flabiano Smorigo <pfsmorigo@xxxxxxxxx> > Cc: Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx> > Cc: Paul Mackerras <paulus@xxxxxxxxx> > Cc: Michael Ellerman <mpe@xxxxxxxxxxxxxx> > Cc: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> > Cc: "David S. Miller" <davem@xxxxxxxxxxxxx> > Cc: linux-crypto@xxxxxxxxxxxxxxx > Cc: linuxppc-dev@xxxxxxxxxxxxxxxx > Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> > --- > v2: fixed build error found by kbuild > > drivers/crypto/nx/nx.c | 4 +- > drivers/crypto/nx/nx.h | 12 +----- > drivers/crypto/nx/nx_debugfs.c | 71 +++++++++++----------------------- > 3 files changed, 26 insertions(+), 61 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt