On Wed, 19 Jun 2019 at 23:42, David Miller <davem@xxxxxxxxxxxxx> wrote: > > From: Ard Biesheuvel <ard.biesheuvel@xxxxxxxxxx> > Date: Wed, 19 Jun 2019 08:55:10 +0200 > > > + ctx->key[0] = (siphash_key_t){ > > + get_unaligned_le64(primary_key), > > + get_unaligned_le64(primary_key + 8) > > + }; > > Please just use normal assignment(s), because not only does this warn > it looks not so nice. > OK Please disregard the v3 I just sent out, v4 has ordinary assignments.