On Fri, 14 Jun 2019 at 12:05, Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > > On Fri, Jun 14, 2019 at 11:43:53AM +0200, Ard Biesheuvel wrote: > > The wusb code takes a very peculiar approach at implementing CBC-MAC, > > by using plain CBC into a scratch buffer, and taking the output IV > > as the MAC. > > > > We can clean up this code substantially by switching to the cbcmac > > shash, as exposed by the CCM template. To ensure that the module is > > loaded on demand, add the cbcmac template name as a module alias. > > > > Signed-off-by: Ard Biesheuvel <ard.biesheuvel@xxxxxxxxxx> > > --- > > v2: - use finup()/digest() where possible, and process b0+b1 using a single > > call to update() > > - make 'stv_hsmic_hs' static const and remove comment regarding GCC 4.1 > > > > NOTE: I don't have any hardware to test this, but the built-in selftest > > still passes. > > No one has this hardware :) > I kind of suspected that :-) > I'll take this, but I think I'll be moving all of the wireless usb code > to staging to drop it in a few kernel versions as there are no users of > it anymore that I can tell. > That is fine. I just wanted to make sure it stops using an interface that I am eager to make private to the crypto subsystem, but the resulting code is arguably better in any case. Thanks,
