On 6/13/2019 3:32 PM, Christophe Leroy wrote: > > > Le 13/06/2019 à 14:24, Horia Geanta a écrit : >> On 6/13/2019 3:16 PM, Christophe Leroy wrote: >>> >>> >>> Le 13/06/2019 à 14:13, Horia Geanta a écrit : >>>> On 6/11/2019 5:39 PM, Christophe Leroy wrote: >>>>> Next patch will require struct talitos_edesc to be defined >>>>> earlier in talitos.c >>>>> >>>>> This patch moves it into talitos.h so that it can be used >>>>> from any place in talitos.c >>>>> >>>>> Fixes: 37b5e8897eb5 ("crypto: talitos - chain in buffered data for ahash on SEC1") >>>>> Cc: stable@xxxxxxxxxxxxxxx >>>>> Signed-off-by: Christophe Leroy <christophe.leroy@xxxxxx> >>>> Again, this patch does not qualify as a fix. >>>> >>> >>> But as I said, the following one is a fix and require that one, you told >>> me to add stable in Cc: to make it explicit it was to go into stable. >> Yes, but you should remove the Fixes tag. >> And probably replace "Next patch" with the commit headline. >> >>> If someone tries to merge following one into stable with taking that one >>> first, build will fail. >> This shouldn't happen, order from main tree should be preserved. >> > > When they pick up fixes, AFAIK they don't take all the preceeding commits. > This is not about Fixes tag, but Cc tag: https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html#option-1 Horia