On Wed, 2019-06-12 at 18:19 +0200, Ard Biesheuvel wrote: > This is a follow-up to, and supersedes [0], which moved some WEP code from > the cipher to the skcipher interface, in order to reduce the use of the bare > cipher interface in non-crypto subsystem code. > > Since using the skcipher interface to invoke the generic C implementation of > an algorithm that is known at compile time is rather pointless, this series > moves those users to a new arc4 library interface instead, which is based on > the existing code. > > Along the way, the arc4 cipher implementation is removed entirely, and only > the ecb(arc4) code is preserved, which is used in a number of places in the > kernel, and is known to be used by at least 'iwd' from user space via the > algif_skcipher API. [...] Looks good to me. Reviewed-by: Johannes Berg <johannes@xxxxxxxxxxxxxxxx> (most closely the first 4 patches) How do you want to handle merging this? I guess keeping all the patches together would be good. I have no objection to the mac80211/lib80211 patches going through any arbitrary tree, this code is hardly ever touched, so highly unlikely to lead to conflicts. johannes