Re: [PATCH v2 3/4] s390/crypto: prng: Use -ENODEV instead of -EOPNOTSUPP

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12.06.19 12:22, David Hildenbrand wrote:
> Let's use the error value that is typically used if HW support is not
> available when trying to load a module - this is also what systemd's
> systemd-modules-load.service expects.
>
> Signed-off-by: David Hildenbrand <david@xxxxxxxxxx>
> ---
>  arch/s390/crypto/prng.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/s390/crypto/prng.c b/arch/s390/crypto/prng.c
> index 12cca467af7d..d977643fa627 100644
> --- a/arch/s390/crypto/prng.c
> +++ b/arch/s390/crypto/prng.c
> @@ -824,7 +824,7 @@ static int __init prng_init(void)
>  
>  	/* check if the CPU has a PRNG */
>  	if (!cpacf_query_func(CPACF_KMC, CPACF_KMC_PRNG))
> -		return -EOPNOTSUPP;
> +		return -ENODEV;
>  
>  	/* check if TRNG subfunction is available */
>  	if (cpacf_query_func(CPACF_PRNO, CPACF_PRNO_TRNG))
> @@ -837,7 +837,7 @@ static int __init prng_init(void)
>  			if (prng_mode == PRNG_MODE_SHA512) {
>  				pr_err("The prng module cannot "
>  				       "start in SHA-512 mode\n");
> -				return -EOPNOTSUPP;
> +				return -ENODEV;
>  			}
>  			prng_mode = PRNG_MODE_TDES;
>  		} else
fine with me
Reviewed-by: Harald Freudenberger <freude@xxxxxxxxxxxxx>




[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]

  Powered by Linux