On Tue, Jun 11, 2019 at 2:56 AM Horia Geanta <horia.geanta@xxxxxxx> wrote: > > On 6/7/2019 11:03 PM, Andrey Smirnov wrote: > > From: Chris Spencer <christopher.spencer@xxxxxxxxx> > > > > There are no clocks that the CAAM driver needs to initialise on the > > i.MX8. > > > RM lists 5 clocks for CAAM module (instance.clock): caam.aclk, caam.ipg_clk, > caam.ipg_clk_s, caam_exsc.aclk_exsc, caam_mem.clk > > Wouldn't it be better to have these clocks in DT, instead of relying that their > root clocks (ccm_ahb_clk_root, ccm_ipg_clk_root) are critical / always on? > Is it even possible to use the SoC in a meaningful way if ccm_ahb_clk_root or ccm_ipg_clk_root are disabled? It doesn't seem that dependency on either is expressed in a consistent manner for other IP blocks in imx8mq.dtsi. OTOH, it should be trivial to add <&clk IMX8MQ_CLK_IPG_ROOT> and <&clk IMX8MQ_CLK_AHB> as "ipg" and "aclk" to CAAM node and it would allow me to drop an extra patch from the series, so I may as well do it. Thanks, Andrey Smirnov
