On Thu, May 30, 2019 at 01:35:06PM +0200, Ondrej Mosnacek wrote: > > Because libkcapi already assumes these values [1] and has code that > uses them. Reserving will allow existing builds of libkcapi to work > correctly once the functionality actually lands in the kernel (if that > ever happens). Of course, it is libkcapi's fault to assume values for > these symbols (in released code) before they are commited in the > kernel, but it seemed easier to just add them along with this patch > rather than creating a confusing situation. > > [1] https://github.com/smuellerDD/libkcapi/blob/master/lib/internal.h#L54 OK but please just leave a gap (or a comment) rather than actually adding these reserved symbols to the kernel. Cheers, -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt