Hi Marcel, On Tue, May 21, 2019 at 12:48 PM Marcel Holtmann <marcel@xxxxxxxxxxxx> wrote: > Hi Ondrej, > > > This patch adds new socket options to AF_ALG that allow setting key from > > kernel keyring. For simplicity, each keyring key type (logon, user, > > trusted, encrypted) has its own socket option name and the value is just > > the key description string that identifies the key to be used. The key > > description doesn't need to be NULL-terminated, but bytes after the > > first zero byte are ignored. > > why use the description instead the actual key id? I wonder if a single socket option and a struct providing the key type and key id might be more useful. I was basing this on the approach taken by dm-crypt/cryptsetup, which is actually the main target consumer for this feature (cryptsetup needs to be able to encrypt/decrypt data using a keyring key (possibly unreadable by userspace) without having to create a temporary dm-crypt mapping, which requires CAP_SYSADMIN). I'm not sure why they didn't just use key IDs there... @Milan/Ondrej, what was you motivation for using key descriptions rather than key IDs? -- Ondrej Mosnacek <omosnace at redhat dot com> Software Engineer, Security Technologies Red Hat, Inc.
