On Fri, May 17, 2019 at 01:40:02AM +1000, Daniel Axtens wrote: > VMX ghash was using a fallback that did not support interleaving simd > and nosimd operations, leading to failures in the extended test suite. > > If I understood correctly, Eric's suggestion was to use the same > data format that the generic code uses, allowing us to call into it > with the same contexts. I wasn't able to get that to work - I think > there's a very different key structure and data layout being used. > > So instead steal the arm64 approach and perform the fallback > operations directly if required. > > Reported-by: Eric Biggers <ebiggers@xxxxxxxxxx> > Signed-off-by: Daniel Axtens <dja@xxxxxxxxxx> > > --- > > Tested on BE and LE in qemu-tcg, so more testing would be lovely. > --- > drivers/crypto/vmx/ghash.c | 211 +++++++++++++++---------------------- > 1 file changed, 86 insertions(+), 125 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt