On 4/12/2019 8:00 AM, Eric Biggers wrote: > So far I've tested all generic, x86, arm, and arm64 algorithms, plus > some PowerPC algorithms. I have not tested hardware drivers. I > encourage people to run the tests on drivers and other architectures, as > they will find more bugs. > I am seeing some errors in caam hardware driver. They are due to error code mismatch b/w generic algorithm implementation and what caam driver returns. Random skcipher tests for block cipher algorithms are expected to fail when input size is not a multiple of algorithm block size. Generic implementation returns -EINVAL. caam driver returns the status received from HW. This probably has to be fixed in caam driver, but I wonder if there's an agreement on what error code should be returned in every single case (since I'll have to do a N:M mapping b/w errors returned by HW and errors expected by crypto API). Should I take the generic S/W implementation as reference? Thanks, Horia
