On Thu, Apr 11, 2019 at 6:06 PM kbuild test robot <lkp@xxxxxxxxx> wrote: > > Hi Atul, > > Thank you for the patch! Perhaps something to improve: > > [auto build test WARNING on crypto/master] > > url: https://github.com/0day-ci/linux/commits/Atul-Gupta/Inline-TLS-client-and-v6-support/20190412-034407 > base: https://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6.git master > config: mips-allmodconfig (attached as .config) > compiler: mips-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0 > reproduce: > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # save the attached .config to linux build tree > GCC_VERSION=7.2.0 make.cross ARCH=mips > > All warnings (new ones prefixed by >>): > > In file included from drivers/crypto/chelsio/chtls/chtls_main.c:19:0: > >> include/net/transp_v6.h:52:33: warning: 'struct ipcm6_cookie' declared inside parameter list will not be visible outside of this definition or declaration > struct flowi6 *fl6, struct ipcm6_cookie *ipc6); > ^~~~~~~~~~~~ The header file does not include every header it depends on. This is not the only instance, but if the only one that triggers, perhaps easiest is to add a forward declaration. diff --git a/include/net/transp_v6.h b/include/net/transp_v6.h index a8f6020f1196e..fef338b08e0fa 100644 --- a/include/net/transp_v6.h +++ b/include/net/transp_v6.h @@ -12,6 +12,7 @@ extern struct proto tcpv6_prot; extern struct proto pingv6_prot; struct flowi6; +struct ipcm6_cookie *ipc6; I can send a separate patch to net-next. But since this patch already changes that file, I would suggest including the one line change in a v2 here. > -- > drivers/crypto/chelsio/chtls/chtls_cm.c: In function 'chtls_pass_accept_request': > >> drivers/crypto/chelsio/chtls/chtls_cm.c:2272:8: warning: 'eh' may be used uninitialized in this function [-Wmaybe-uninitialized] > ip6h = (struct ipv6hdr *)(eh + 1); > ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~ > drivers/crypto/chelsio/chtls/chtls_cm.c: In function 'chtls_v6_connect': > >> drivers/crypto/chelsio/chtls/chtls_cm.c:1552:12: warning: 'saddr' may be used uninitialized in this function [-Wmaybe-uninitialized] > fl6.saddr = saddr ? *saddr : np->saddr; > ~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > vim +52 include/net/transp_v6.h > > f145b67f2 Joe Perches 2013-06-02 42 > 4b261c75a Hannes Frederic Sowa 2014-01-20 43 /* this does all the common and the specific ctl work */ > 4b261c75a Hannes Frederic Sowa 2014-01-20 44 void ip6_datagram_recv_ctl(struct sock *sk, struct msghdr *msg, > 4b261c75a Hannes Frederic Sowa 2014-01-20 45 struct sk_buff *skb); > 4b261c75a Hannes Frederic Sowa 2014-01-20 46 void ip6_datagram_recv_common_ctl(struct sock *sk, struct msghdr *msg, > 4b261c75a Hannes Frederic Sowa 2014-01-20 47 struct sk_buff *skb); > 4b261c75a Hannes Frederic Sowa 2014-01-20 48 void ip6_datagram_recv_specific_ctl(struct sock *sk, struct msghdr *msg, > ^1da177e4 Linus Torvalds 2005-04-16 49 struct sk_buff *skb); > ^1da177e4 Linus Torvalds 2005-04-16 50 > f145b67f2 Joe Perches 2013-06-02 51 int ip6_datagram_send_ctl(struct net *net, struct sock *sk, struct msghdr *msg, > 5fdaa88df Willem de Bruijn 2018-07-06 @52 struct flowi6 *fl6, struct ipcm6_cookie *ipc6); > ^1da177e4 Linus Torvalds 2005-04-16 53 > > :::::: The code at line 52 was first introduced by commit > :::::: 5fdaa88dfefa87ee1ea92750e99950dca182ea41 ipv6: fold sockcm_cookie into ipcm6_cookie > > :::::: TO: Willem de Bruijn <willemb@xxxxxxxxxx> > :::::: CC: David S. Miller <davem@xxxxxxxxxxxxx> > > --- > 0-DAY kernel test infrastructure Open Source Technology Center > https://lists.01.org/pipermail/kbuild-all Intel Corporation
