Re: [PATCH v3] HID: add driver for U2F Zero built-in LED and RNG

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Apr 10, 2019 at 3:14 PM Jiri Kosina <jikos@xxxxxxxxxx> wrote:
>
> On Mon, 1 Apr 2019, Andrej Shadura wrote:
>
> > U2F Zero supports custom commands for blinking the LED and getting data
> > from the internal hardware RNG. Expose the blinking function as a LED
> > device, and the internal hardware RNG as an HWRNG so that it can be used
> > to feed the enthropy pool.
>
> So I still am not really happy about this being wired up into generic HID
> although it's really a USB driver, but we've discussed that already, and I
> don't see any option that'd work substantially better in this case,
> especially from the UX point of view. Oh well. Applied to for-5.2/u2fzero,
> thanks!
>

Hi wish I were CC-ed on these threads.

My CI script now fails because hid-u2fzero.ko needs
devm_hwrng_register and the Kconfig doesn't force pulling the right
dependency.

Also, you probably want to add in .probe() a check for the actual
transport driver (`hid_is_using_ll_driver(hdev, &usb_hid_driver)`) or
you can not use the usbhid functions without crashing the kernel.

Cheers,
Benjamin



[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]

  Powered by Linux