Re: [PATCH v2] HID: add driver for U2F Zero built-in LED and RNG

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 18 Mar 2019, Andrej Shadura wrote:

> > 
> > This driver isn't really a generic (transport-agnostic) one (which also 
> > means it's missing USB dependency in Kconfig btw).
> 
> Thanks, I forgot that one.
> 
> > Is there a reason why it can't be abstracted that way so that it'd fit our 
> > principal model in HID subsystem?
> 
> I tried and I failed. The HID subsystem doesn’t provide the 
> functionality necessary to implement the protocol, or maybe I’m missing 
> something, but I haven’t found a way.

After reading through the driver, I tend to agree that this is the least 
painful way, so it's probably worth violating our usual mode of operation 
a bit :)

So could you please resend with the proper USB dependency added?

Thanks,

-- 
Jiri Kosina
SUSE Labs




[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]

  Powered by Linux