Hi Eric and Gael,
On 2019/3/22 上午1:04, Gael PORTAY wrote:
Hello,
On 3/18/19 11:03 AM, Gael PORTAY wrote:
Hello,
On 3/16/19 6:31 PM, Ezequiel Garcia wrote:
Adding my colleague Gael, who has been working on fixing this driver.
I have a couple of pending commits that may fix that issue.
I will give it a try, and get back to you then.
The patches I had fix the same issue than recent commit to [1] and [2]
in a different way.
But they do not fix the issue below.
I will try to fix the issue below.
...
Thanks for the fixes, but I've improved the self-tests more, and
there is
another bug. See the KernelCI job here:
https://kernelci.org/boot/all/job/ardb/branch/for-kernelci/kernel/v5.0-11071-g7d597cc3f0ef/
The self-tests are failing on the rk3288-rock2-square platform:
alg: skcipher: cbc-aes-rk encryption test failed (wrong output
IV) on test vector 0, cfg=\"in-place\"
alg: skcipher: cbc-des-rk encryption test failed (wrong output
IV) on test vector 0, cfg=\"in-place\"
alg: skcipher: cbc-des3-ede-rk encryption test failed (wrong
output IV) on test vector 0, cfg=\"in-place\"
The issue is that the self-tests now verify that CBC
implementations update the
IV buffer to contain the next IV, aka the last ciphertext block.
But the
Rockchip crypto driver doesn't do that, so it needs to be fixed.
This has always been a requirement for CBC implementations so that
users can
chain CBC requests. Unfortunately it was just never tested for...
This should be easily reproducible using the mainline kernel.
- Eric
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Gael
[1]:
https://github.com/torvalds/linux/commit/c1c214adcb56d36433480c8fedf772498e7e539c#diff-440313f9d25f65c14d4bffb1360a3c60
[2]:
https://github.com/torvalds/linux/commit/4359669a087633132203c52d67dd8c31e09e7b2e#diff-440313f9d25f65c14d4bffb1360a3c60
Gael
