On Thu, Mar 07, 2019 at 04:15:55PM -0800, Joe Perches wrote: > Normal use of IS_ENABLED is with a CONFIG_<SYMBOL> and > there is no -DDEBUG in the Makefile here. > > Replace the IS_ENABLED(DEBUG) with #ifdef DEBUG/#endif > blocks. > > Miscellanea: > > o Move the sahara_state array into the function that uses it. > > Signed-off-by: Joe Perches <joe@xxxxxxxxxxx> > --- > drivers/crypto/sahara.c | 20 +++++++++----------- > 1 file changed, 9 insertions(+), 11 deletions(-) Even if this is correct this is way too ugly. The original code at least compiled everything regardless of macros. Your new code won't detect compile errors in debugging code unless debugging is enabled. Cheers, -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
