On 3/15/2019 1:25 PM, Vakul Garg wrote: > For each job ring, the variable 'ringsize' is initialised but never > used. Similarly variables 'inp_ring_read_index' and 'head' always track > the same value and instead of 'inp_ring_read_index', caam_jr_enqueue() > can use 'head' itself. Both these variables have been removed. > Typo: s/inp_ring_read_index/inp_ring_write_index > - int inp_ring_write_index; /* Input index "tail" */ [snip] > - jrp->inpring[jrp->inp_ring_write_index] = cpu_to_caam_dma(desc_dma); > + jrp->inpring[head] = cpu_to_caam_dma(desc_dma); [snip] > - jrp->inp_ring_write_index = (jrp->inp_ring_write_index + 1) & > - (JOBR_DEPTH - 1); [snip] > - jrp->inp_ring_write_index = 0; Horia