Hi Vakul, On Fri, 15 Mar 2019 at 04:05, Vakul Garg <vakul.garg@xxxxxxx> wrote: > For each job ring pair, the output ring is processed exactly by one cpu > at a time under a tasklet context (one per ring). Therefore, there is no > need to protect a job ring's access & its private data structure using a > lock. Hence the lock can be removed. > > Signed-off-by: Vakul Garg <vakul.garg@xxxxxxx> This comment in caam_jr_dequeue doesn't really make sense anymore: /* Stash callback params for use outside of lock */ Since the lock has been removed you could probably get away with just invoking the user callback immediately which would simplify the code a little. Thanks, Chris
