On Mon, 25 Feb 2019 at 14:17, Chris Spencer <spencercw@xxxxxxxxx> wrote: > On Mon, 25 Feb 2019 at 14:03, Horia Geanta <horia.geanta@xxxxxxx> wrote: > > The code looks *very* similar to what was developed by NXP. > > Why have you stripped off the S-O-Bs? > > Hi Horia, > > Apologies, I was struggling to find any guidance about what to do with > the tags when upstreaming changes. I will add them in the next > version. > > Thanks, > Chris Horia, Just want to clear this up a bit to make sure I'm doing the right thing (this is my first kernel patch so forgive my missteps). These are the origins of the patches and the SOBs I will add: 2/4 is based entirely on [1], except I have only applied the changes relevant to the i.MX8MQ. I will add: Signed-off-by: Aymen Sghaier <aymen.sghaier@xxxxxxx> 3/4 is an amalgamation of [2], [3] and [4], as well as a fix of my own (in the downstream version of pdb.h, rsa_priv_f2_pdb and rsa_priv_f3_pdb use dma_addr_t which causes a test failure; they should be using caam_dma_addr_t). I will add: Signed-off-by: Franck LENORMAND <franck.lenormand@xxxxxxx> Signed-off-by: Aymen Sghaier <aymen.sghaier@xxxxxxx> 4/4 is an amalgamation of [5], [6] and [7], lightly modified to drop the i.MX8Q bits. I will add: Signed-off-by: Franck LENORMAND <franck.lenormand@xxxxxxx> Signed-off-by: Aymen Sghaier <aymen.sghaier@xxxxxxx> It's not really clear to me what the From address should be. They are all under my name in my repo, but the changes are almost entirely based on those authored by NXP, so I'm not sure whether that's ok/correct. Thanks, Chris [1] MLK-15473-1: crypto: caam: Add CAAM driver support for iMX8 soc family https://source.codeaurora.org/external/imx/linux-imx/commit/drivers/crypto/caam?h=imx_4.14.78_1.0.0_ga&id=afa53c2c96a54b4432a26372e3b5e7dbccbb9671 [2] MLK-18082: crypto: caam: Fix DMA coherency configuration https://source.codeaurora.org/external/imx/linux-imx/commit/drivers/crypto/caam?h=imx_4.14.78_1.0.0_ga&id=d07274fcddde4258e63edf2a77dc29aef19a0d27 [3] MLK-17233: Fix CAAM pointer size error for i.MX8 https://source.codeaurora.org/external/imx/linux-imx/commit/drivers/crypto/caam?h=imx_4.14.78_1.0.0_ga&id=09a35f4ff6e7a6fb93db6f0b0ec30c1c6c25df34 [4] MLK-18082: crypto: caam: Check ret value of dma_set_mask_and_coherent https://source.codeaurora.org/external/imx/linux-imx/commit/drivers/crypto/caam?h=imx_4.14.78_1.0.0_ga&id=278d4b127292943eaeb49f23d8a99598ea8954bd [5] MLK-18082: crypto: caam: Move RNG instantation https://source.codeaurora.org/external/imx/linux-imx/commit/drivers/crypto/caam?h=imx_4.14.78_1.0.0_ga&id=5fd8fe866172c38e8cd07741d98d79b995f05bc9 [6] MLK-17111-1: crypto: caam: Fix RNG instantiation retry https://source.codeaurora.org/external/imx/linux-imx/commit/drivers/crypto/caam?h=imx_4.14.78_1.0.0_ga&id=031caf182221da24cd41d4cacf4c81fe1897249f [7] MLK-17227: crypto: caam: Update CAAM driver verbosity while RNG init https://source.codeaurora.org/external/imx/linux-imx/commit/drivers/crypto/caam?h=imx_4.14.78_1.0.0_ga&id=bc328d847a575082472d7aebbfe0610c5adde32a
