Re: [PATCH] crypto: ccp - Update driver messages to remove some confusion

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Feb 15, 2019 at 05:26:33PM +0000, Lendacky, Thomas wrote:
> The current content of some of the driver messages and the way that they
> are issued results in some confusion, especially in the area of the PSP
> as it relates to SEV support. If SEV is not supported, a message is issued
> that says "psp initialization failed." This makes it seem like there was
> a problem, when in fact, the PSP support is just disabled if SEV is not
> supported.
> 
> Update the driver to check SEV support a bit earlier and issue a debug-
> level message if SEV is not supported, followed by a debug-level message
> that the PSP is disabled. This way you will only see PSP messages if SEV
> is supported or if debug information is desired. Also, remove the overall
> "enabled" and "disabled" messages for the driver and rely on the CCP and
> PSP support to issue component-specific messages.
> 
> Signed-off-by: Tom Lendacky <thomas.lendacky@xxxxxxx>
> ---
>  drivers/crypto/ccp/psp-dev.c |   19 ++++++++++++++-----
>  drivers/crypto/ccp/sp-pci.c  |    4 ----
>  2 files changed, 14 insertions(+), 9 deletions(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt



[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]

  Powered by Linux