On 20/02/2019 10:37, Ard Biesheuvel wrote: > On Wed, 20 Feb 2019 at 11:34, Sumit Garg <sumit.garg@xxxxxxxxxx> wrote: >> >> On Wed, 20 Feb 2019 at 14:51, Wei Yongjun <weiyongjun1@xxxxxxxxxx> wrote: >>> >>> Fixes the following sparse warning: >>> >>> drivers/char/hw_random/optee-rng.c:265:35: warning: >>> symbol 'optee_rng_id_table' was not declared. Should it be static? >>> >> >> I haven't observed this warning during my normal Linux build using >> gcc. Is there any specific configuration you are using? >> > > This is a sparse warning, not GCC. You need to install it separately > and build with C=1 (iirc) > It's useful to may these symbols static just to reduce the scope and there is on-going work to fix these symbols up across the entire kernel