On Fri, Feb 08, 2019 at 09:55:19AM +0100, Ard Biesheuvel wrote: > > So I would argue that the generic GCM driver should ensure that > whatever it passes into scatterlists is safe for non-cache coherent > DMA. Blowing up the struct like this is probably not the right answer, > instead, we should probably have an auth_tag pointer and a separate > kmalloc buffer so we don't affect cache coherent architectures too > much. Yes I agree. GCM needs to ensure auth_tag is aligned properly. Thanks, -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
