On Fri, Jan 18, 2019 at 12:14:18AM +0100, Thomas Gleixner wrote: > Precise and non-ambiguous license information is important. The recently > added aegis header file has a SPDX license identifier, which is nice, but > at the same time it has a contradictionary license boiler plate text. > > SPDX-License-Identifier: GPL-2.0 > > versus > > * This program is free software; you can redistribute it and/or modify it > * under the terms of the GNU General Public License as published by the Free > * Software Foundation; either version 2 of the License, or (at your option) > * any later version > > Oh well. > > As the other aegis related files are licensed under the GPL v2 or later, > it's assumed that the boiler plate code is correct, but the SPDX license > identifier is wrong. > > Fix the SPDX identifier and remove the boiler plate as it is redundant. > > Fixes: f606a88e5823 ("crypto: aegis - Add generic AEGIS AEAD implementations") > Signed-off-by: Thomas Gleixner <tglx@xxxxxxxxxxxxx> > Cc: Ondrej Mosnacek <omosnacek@xxxxxxxxx> > Cc: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> > Cc: "David S. Miller" <davem@xxxxxxxxxxxxx> > Cc: linux-crypto@xxxxxxxxxxxxxxx > --- > > P.S.: This patch is part of a larger cleanup, but independent of other > patches and is intended to be picked up by the maintainer directly. > > --- > crypto/aegis.h | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) Patches 2-5 applied. Thanks. -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt