On 2019/1/18 12:55, Herbert Xu wrote: > On Wed, Jan 16, 2019 at 10:12:47PM +0800, Zhou Wang wrote: >> >> A stupid question: how do we test scomp alg? >> >> It seems we can not use general comp API, e.g. crypto_alloc_comp >> to do this. >> >> Could you give me any clue about this? > > scomp algorithms are allocated through crypto_alloc_acomp. A little strange, but let me try firstly. However, another question is that seems other subsystems in kernel, e.g. zswap still use crypto_alloc_comp. So we'd better register this ZIP engine using both cryto_alloc_comp and scomp/acomp interface to make it compatible with other subsystems? Best, Zhou > > Thanks, >