On 2019/1/17 1:49, Eric Biggers wrote: > On Wed, Jan 16, 2019 at 10:50:29AM +0800, Xiongfeng Wang wrote: >> The patchset introduce a helper to (un)register a array of crypto templates. >> The following patches use this helper to simplify the code. This is also >> a preparation for a coming patchset, which will register several crypto >> templates. >> >> Xiongfeng Wang (5): >> crypto: api - add a helper to (un)register a array of templates >> crypto: ccm - use template array registering API to simplify the code >> crypto: gcm - use template array registering API to simplify the code >> crypto: ctr - use template array registering API to simplify the code >> crypto: chacha20poly1305 - use template array registering API to >> simplify the code >> >> crypto/algapi.c | 27 ++++++++++++++++ >> crypto/ccm.c | 81 +++++++++++++++-------------------------------- >> crypto/chacha20poly1305.c | 38 +++++++++------------- >> crypto/ctr.c | 46 ++++++++++----------------- >> crypto/gcm.c | 76 +++++++++++++++----------------------------- >> include/crypto/algapi.h | 2 ++ >> 6 files changed, 113 insertions(+), 157 deletions(-) >> >> -- >> 1.7.12.4 >> > > Hi Xiongfeng, I think this a useful cleanup but can you please rebase this onto > cryptodev? There is a conflict in crypto/ctr.c. Hi Eric, thanks for your reply. I will change it in the next version. Thanks, Xiongfeng > > - Eric > > . >