On Fri, Jan 11, 2019 at 02:33:58PM +0800, Herbert Xu wrote: > On Thu, Jan 03, 2019 at 08:16:09PM -0800, Eric Biggers wrote: > > Hello, > > > > This series adds a function skcipher_alloc_instance_simple() that > > greatly simplifies creating an skcipher_instance that uses a single > > underlying block cipher. It then converts the cbc, cfb, ctr, ecb, kw, > > ofb, and pcbc templates to use it. In doing so, ctr, ecb, and kw are > > also converted from the deprecated "blkcipher" API to the skcipher API. > > > > While doing this, I also found some rather silly bugs in the cfb, ofb, > > and pcbc templates... So I've included the fixes for these first, in > > patches 1-4. Please consider taking these first 4 patches through > > 'crypto' rather than 'cryptodev'. (But 5-16 are cleanups only, so no > > rush on those.) > > I have decided to push all of these through cryptodev because > it's not clear whether the first four bug fixes are serious enough > to warrant going through straight away. If I'm wrong please let > me know. > I'm fine with cryptodev. - Eric
