Re: [PATCH] crypto: remove remnants of internal IV generators

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Dec 16, 2018 at 03:55:06PM -0800, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@xxxxxxxxxx>
> 
> Remove dead code related to internal IV generators, which are no longer
> used since they've been replaced with the "seqiv" and "echainiv"
> templates.  The removed code includes:
> 
> - The "givcipher" (GIVCIPHER) algorithm type.  No algorithms are
>   registered with this type anymore, so it's unneeded.
> 
> - The "const char *geniv" member of aead_alg, ablkcipher_alg, and
>   blkcipher_alg.  A few algorithms still set this, but it isn't used
>   anymore except to show via /proc/crypto and CRYPTO_MSG_GETALG.
>   Just hardcode "<default>" or "<none>" in those cases.
> 
> - The 'skcipher_givcrypt_request' structure, which is never used.
> 
> Signed-off-by: Eric Biggers <ebiggers@xxxxxxxxxx>
> ---
>  Documentation/crypto/api.rst          |  9 ----
>  Documentation/crypto/architecture.rst | 31 ++---------
>  crypto/ablkcipher.c                   | 76 +--------------------------
>  crypto/blkcipher.c                    |  6 +--
>  crypto/cryptd.c                       |  4 +-
>  crypto/ctr.c                          |  2 -
>  crypto/skcipher.c                     |  6 +--
>  drivers/crypto/bcm/cipher.c           |  1 -
>  drivers/crypto/chelsio/chcr_algo.c    |  1 -
>  drivers/crypto/ixp4xx_crypto.c        |  5 --
>  drivers/crypto/nx/nx-aes-ctr.c        |  1 -
>  drivers/crypto/omap-aes.c             |  1 -
>  drivers/crypto/picoxcell_crypto.c     |  3 +-
>  drivers/crypto/talitos.c              |  1 -
>  include/crypto/aead.h                 |  3 --
>  include/crypto/internal/skcipher.h    |  2 -
>  include/crypto/skcipher.h             | 13 -----
>  include/linux/crypto.h                | 34 ++----------
>  18 files changed, 17 insertions(+), 182 deletions(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt



[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]

  Powered by Linux