Re: [PATCH] crypto: drop mask=CRYPTO_ALG_ASYNC from 'cipher' tfm allocations

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Nov 14, 2018 at 12:19:39PM -0800, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@xxxxxxxxxx>
> 
> 'cipher' algorithms (single block ciphers) are always synchronous, so
> passing CRYPTO_ALG_ASYNC in the mask to crypto_alloc_cipher() has no
> effect.  Many users therefore already don't pass it, but some still do.
> This inconsistency can cause confusion, especially since the way the
> 'mask' argument works is somewhat counterintuitive.
> 
> Thus, just remove the unneeded CRYPTO_ALG_ASYNC flags.
> 
> This patch shouldn't change any actual behavior.
> 
> Signed-off-by: Eric Biggers <ebiggers@xxxxxxxxxx>
> ---
>  arch/s390/crypto/aes_s390.c                               | 2 +-
>  drivers/crypto/amcc/crypto4xx_alg.c                       | 3 +--
>  drivers/crypto/ccp/ccp-crypto-aes-cmac.c                  | 4 +---
>  drivers/crypto/geode-aes.c                                | 2 +-
>  drivers/md/dm-crypt.c                                     | 2 +-
>  drivers/net/wireless/cisco/airo.c                         | 2 +-
>  drivers/staging/rtl8192e/rtllib_crypt_ccmp.c              | 2 +-
>  drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_ccmp.c | 2 +-
>  drivers/usb/wusbcore/crypto.c                             | 2 +-
>  net/bluetooth/smp.c                                       | 6 +++---
>  net/mac80211/wep.c                                        | 4 ++--
>  net/wireless/lib80211_crypt_ccmp.c                        | 2 +-
>  net/wireless/lib80211_crypt_tkip.c                        | 4 ++--
>  net/wireless/lib80211_crypt_wep.c                         | 4 ++--
>  14 files changed, 19 insertions(+), 22 deletions(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt



[Index of Archives]     [Kernel]     [Gnu Classpath]     [Gnu Crypto]     [DM Crypt]     [Netfilter]     [Bugtraq]

  Powered by Linux