On Mon, Nov 19, 2018 at 01:24:51PM +0800, Herbert Xu wrote: > > In response to Martin's patch-set which I merged last week, I think > here is quick way out for the zinc interface. > > Going through the past zinc discussions it would appear that > everybody is quite happy with the zinc interface per se. The > most contentious areas are in fact the algorithm implementations > under zinc, as well as the conversion of the crypto API algorithms > over to using the zinc interface (e.g., you can no longer access > specific implementations). > > My proposal is to merge the zinc interface as is, but to invert > how we place the algorithm implementations. IOW the implementations > should stay where they are now, with in the crypto API. However, > we will provide direct access to them for zinc without going through > the crypto API. IOW we'll just export the functions directly. > > Here is a proof of concept patch to do it for chacha20-generic. > It basically replaces patch 3 in the October zinc patch series. > Actually this patch also exports the arm/x86 chacha20 functions > too so they are ready for use by zinc. > > If everyone is happy with this then we can immediately add the > zinc interface and expose the existing crypto API algorithms > through it. This would allow wireguard to be merged right away. > > In parallel, the discussions over replacing the implementations > underneath can carry on without stalling the whole project. > > PS This patch is totally untested :) Here is an updated version demonstrating how we could access the accelerated versions of chacha20. It also includes a final patch to deposit the new zinc version of x86-64 chacha20 into arch/x86/crypto where it can be used by both the crypto API as well as zinc. The key differences between this and the last zinc patch series: 1. The crypto API algorithms remain individually accessible, this is crucial as these algorithm names are exported to user-space so changing the names to foo-zinc is not going to work. 2. The arch-specific algorithm code lives in their own module rather than in a monolithic module. Cheers, -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
