On Mon, Nov 19, 2018 at 02:54:15PM -0800, Eric Biggers wrote: > > > I think the remaining issue right now is how to order my series and > > Eric's series. If Eric's goes in first, it means that I can either a) > > spend some time developing Zinc further _now_ to support chacha12 and > > keep the top two conversion patches, or b) just drop the top two > > conversion patches and work that out carefully with Eric after. I > > think (b) would be better, but I'm happy to do (a) if you disagree. > > And as I mentioned in the last email, I'd prefer Eric's work to go in > > after Zinc, but I don't think the reasoning for that is particularly > > strong, so it seems fine to merge Eric's work first. > > > > I'll post v9 pretty soon and you can see how things are shaping up. > > Hopefully before then Eric/Ard/you can provide some feedback on > > whether you'd prefer (a) or (b) above. > > > > I'd still prefer to see the conversion patches included. Skipping them would be > kicking the can down the road and avoiding issues that will need to be addressed > anyway. Like you, I don't want a "half-baked concoction that will be maybe > possibly be replaced 'later'" :-) Are you guys talking about the conversion patches to eliminate the two copies of chacha code that would otherwise exist in crypto as well as in zinc? If so I think that's not negotiable. Having two copies of the same code is just not acceptable. Cheers, -- Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt