On Tue, Nov 20, 2018 at 12:15:17AM +0100, Jason A. Donenfeld wrote: > Hi Eric, > > On Mon, Nov 19, 2018 at 11:54 PM Eric Biggers <ebiggers@xxxxxxxxxx> wrote: > > Will v9 include a documentation file for Zinc in Documentation/crypto/? > > That's been suggested several times. > > I had started writing that there, but then thought that the requested > information could go in the commit message instead. But I'm guessing > you're asking again now because you poked into the repo and didn't > find the Documentation/, so presumably you still want it. I can > reorganize the presentation of that to be more suitable for > Documentation/, and I'll have that for v9. > It's much better to have the documentation in a permanent location. > > I'd still prefer to see the conversion patches included. Skipping them would be > > kicking the can down the road and avoiding issues that will need to be addressed > > anyway. Like you, I don't want a "half-baked concoction that will be maybe > > possibly be replaced 'later'" :-) > > Okay, fair enough. Will do. > > > Either way though, it would make things much easier if you at least named the > > files, structures, constants, etc. "ChaCha" rather than "ChaCha20" from the > > start where appropriate. For an example, see the commit "crypto: chacha - > > prepare for supporting non-20-round variants" on my "adiantum-zinc" branch: > > https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/linux.git/commit/?h=adiantum-zinc&id=754af8d7d39f31238114426e39786c84d7cc0f98 > > Then the actual introduction of the 12-round variant is much less noisy. > > That's a good idea. I'll do it like that. I'll likely order it as what > we have now (renamed to omit the 20), and then put the 12 stuff on top > of that, so it's easier to see what's changed in the process. I > noticed in that branch, you didn't port the assembly to support fewer > rounds. Shall I follow suite, and then expect patches from you later > doing that? Or were you expecting me to also port the architecture > implementations to chacha12 as well? > I actually did add ChaCha12 support to most of the Zinc assembly in "[WIP] crypto: assembly support for ChaCha12" (https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/linux.git/commit/?h=adiantum-zinc&id=0a7787a515a977e11b680f1752b430ca1744e399). But I skipped AVX-512 and MIPS since I didn't have a way to test those yet, and I haven't ported the changes to your new perl scripts yet. - Eric
